etseidl commented on PR #10106: URL: https://github.com/apache/arrow-rs/pull/10106#issuecomment-4772866330
> @etseidl Can we ask someone to review this PR? I'd like to start a vote on the INT96 changes soon, but we should get some eyes on this PR before that. @divjotarora I don't think it's strictly necessary to have this reviewed before the spec change. More important would be to show that the PoCs can read each others files. Ideally we'd add a file to parquet-testing with the new sort order specified and make sure the new readers correctly get the stats, and old readers hopefully ignore the stats, but at least don't die when trying to read the file. If anyone (@alamb or @jhorstmann perhaps) has time for a quick look, the changes for this PR can be viewed [here](https://github.com/etseidl/arrow-rs/compare/deprecate_sort_order_for_type...etseidl:arrow-rs:int96_order) (diff against the branch from #10104). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
