Reranko05 commented on code in PR #50234:
URL: https://github.com/apache/arrow/pull/50234#discussion_r3457423184
##########
ruby/red-arrow/ext/arrow/memory-view.cpp:
##########
@@ -220,6 +221,7 @@ namespace red_arrow {
return false;
}
auto view_ = reinterpret_cast<memory_view *>(view);
+ memset(view_, 0, sizeof(memory_view));
Review Comment:
Removed rendundant assignments
##########
ruby/red-arrow/test/test-memory-view.rb:
##########
@@ -431,4 +431,56 @@ def little_endian?
])
end
end
+
+ sub_test_case("uninitialized rb_memory_view_t") do
+ def setup
+ libruby = Fiddle.dlopen(nil)
+
+ @rb_memory_view_get = Fiddle::Function.new(
+ libruby["rb_memory_view_get"],
+ [
+ Fiddle::TYPE_UINTPTR_T,
+ Fiddle::TYPE_VOIDP,
+ Fiddle::TYPE_INT,
+ ],
+ Fiddle::TYPE_BOOL
+ )
+
+ @rb_memory_view_release = Fiddle::Function.new(
+ libruby["rb_memory_view_release"],
+ [
+ Fiddle::TYPE_VOIDP,
+ ],
+ Fiddle::TYPE_BOOL
+ )
+ end
+
+ def assert_release(target)
+ Fiddle::Pointer.malloc(256, Fiddle::RUBY_FREE) do |view|
+ 256.times do |i|
+ view[i] = 0xAA
+ end
+
+ assert_equal(
+ true,
+ @rb_memory_view_get.call(Fiddle.dlwrap(target), view, 0)
+ )
Review Comment:
Addressed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
