rluvaton commented on code in PR #10118:
URL: https://github.com/apache/arrow-rs/pull/10118#discussion_r3458253645
##########
arrow-buffer/src/buffer/immutable.rs:
##########
@@ -358,10 +365,12 @@ impl Buffer {
UnalignedBitChunk::new(self.as_slice(), offset, len).count_ones()
}
- /// Returns `MutableBuffer` for mutating the buffer if this buffer is not
shared.
- /// Returns `Err` if this is shared or its allocation is from an external
source or
+ /// Returns `MutableBuffer` for mutating the buffer if this buffer is not
shared or sliced.
Review Comment:
Updated the code to return Err(self) if sliced but only ptr_offset is
greater than 0
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
