rok commented on PR #50203: URL: https://github.com/apache/arrow/pull/50203#issuecomment-4779504379
> 2. Cython: validate each element's shape against the tensor's shape (so (3,2) into (2,3) errors), and reject permuted types with a clear error for now, with full permutation support as a follow-up, unless you'd prefer I handle the transpose here. Permuted output types would best fit into a follow-up issue indeed. As for non-C ordered input types - if we have a clean way to handle them (e.g. always convert them to C) and document that in the function docs I think that'd be ok. It doesn't seem likely we'll have requests for non-C orders anytime soon, but we should guard against misinterpretation of non-C ordered data. > Does this direction sound right before I work on it? Yes! Please proceed. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
