zeroshade commented on code in PR #4398:
URL: https://github.com/apache/arrow-adbc/pull/4398#discussion_r3460964819
##########
java/driver/jni/src/main/cpp/jni_wrapper.cc:
##########
@@ -414,6 +414,7 @@
Java_org_apache_arrow_adbc_driver_jni_impl_NativeAdbc_openDatabase(
jclass nativeHandleKlass = RequireImplClass(env, "NativeDatabaseHandle");
jmethodID nativeHandleCtor = RequireMethod(env, nativeHandleKlass,
"<init>", "(J)V");
const jsize num_params = env->GetArrayLength(parameters);
+ if (env->ExceptionCheck()) return nullptr;
Review Comment:
returning null is the correct behavior as opposed to throwing the exception
or otherwise explicitly propagating it?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
