alamb commented on code in PR #10202:
URL: https://github.com/apache/arrow-rs/pull/10202#discussion_r3462450393


##########
arrow-flight/benches/flight.rs:
##########
@@ -66,6 +67,43 @@ async fn roundtrip(channel: Channel, batch: RecordBatch) {
         .unwrap();
 }
 
+fn bench_decode(c: &mut Criterion) {
+    let rt = tokio::runtime::Runtime::new().unwrap();
+    let mut g = c.benchmark_group("decode");
+
+    for &(name, build) in TYPES {
+        for &rows in &ROWS {
+            for &cols in &COLS {
+                let batch = build_batch(name, rows, cols, build);
+                let frames: Vec<FlightData> = rt
+                    .block_on(
+                        FlightDataEncoderBuilder::new()

Review Comment:
   I was wondering if it also made sense to benchmark decoding more than one 
batch (for example, a stream with replacement dictionary) but I think for now 
this is good



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to