alamb commented on code in PR #10199:
URL: https://github.com/apache/arrow-rs/pull/10199#discussion_r3462482325
##########
arrow/benches/merge_kernels.rs:
##########
@@ -188,14 +188,14 @@ fn bench_merge_on_input_generator(c: &mut Criterion,
input_generator: &impl Inpu
&mut group,
&masks,
&array_1_10pct_nulls,
- &non_null_scalar_1,
+ &Scalar::new(non_null_scalar_1.clone()),
);
bench_merge_input_on_all_masks(
"non_null_scalar_vs_array",
&mut group,
&masks,
- &non_null_scalar_1,
+ &Scalar::new(non_null_scalar_1.clone()),
Review Comment:
I verified this panic on main with
```shell
cargo bench --bench merge_kernels --profile=dev -- non_null_scalar_vs_array
...
Benchmarking merge_8192_from_i32/non_null_scalar_vs_array/all_true: Warming
up for 3.0000 s
thread 'main' (115763431) panicked at
arrow-data/src/transform/primitive.rs:31:43:
range end index 8192 out of range for slice of length 1
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace
error: bench failed, to rerun pass `-p arrow --bench merge_kernels`
```
##########
arrow/benches/merge_kernels.rs:
##########
@@ -188,14 +188,14 @@ fn bench_merge_on_input_generator(c: &mut Criterion,
input_generator: &impl Inpu
&mut group,
&masks,
&array_1_10pct_nulls,
- &non_null_scalar_1,
+ &Scalar::new(non_null_scalar_1.clone()),
Review Comment:
I verified this panic on main with
```shell
cargo bench --bench merge_kernels --profile=dev -- array_vs_non_null_scalar
...
Benchmarking merge_8192_from_i32/array_vs_non_null_scalar/99pct_true:
Warming up for 3.0000 s
thread 'main' (115764966) panicked at
arrow-data/src/transform/primitive.rs:31:43:
range end index 2 out of range for slice of length 1
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace
error: bench failed, to rerun pass `-p arrow --bench merge_kernels`
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
