lidavidm commented on code in PR #858:
URL: https://github.com/apache/arrow-go/pull/858#discussion_r3463301007
##########
arrow/array/record.go:
##########
@@ -385,11 +407,26 @@ func (b *RecordBuilder) Resize(n int) {
//
// The returned RecordBatch must be Release()'d after use.
//
-// NewRecordBatch panics if the fields' builder do not have the same length.
+// NewRecordBatch panics if the fields' builders do not have the same length
or if
+// a non-nullable field contains nulls. Use NewRecordBatchChecked for an error.
Review Comment:
Um, I'm not sure if I'm talking to you or a bot, but I'd think accidentally
inserting a null (especially because nullable defaults to false due to false
being the zero value) is far more common, and a panic is fairly unwelcome.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
