Shally-Katariya opened a new pull request, #50245:
URL: https://github.com/apache/arrow/pull/50245
### Rationale for this change
Many APIs in `arrow/ipc/metadata_internal.h` used a `T* out` parameter
for output and returned a `Status`. This migrates those APIs to return
`Result<T>` instead, which is the modern Arrow C++ convention.
### What changes are included in this PR?
Migrated the following functions from `Status` + output parameter pattern
to `Result<T>`:
- `GetKeyValueMetadata`
- `WriteSchemaMessage`
- `WriteRecordBatchMessage`
- `WriteDictionaryMessage`
Updated all call sites in:
- `arrow/ipc/metadata_internal.cc`
- `arrow/ipc/reader.cc`
- `arrow/ipc/message.cc`
- `arrow/ipc/writer.cc`
- `arrow/ipc/message_internal_test.cc`
- `arrow/ipc/read_write_test.cc`
### Are these changes tested?
Yes. All existing IPC tests pass:
- `arrow-ipc-message-internal-test`: 8/8 passed
- `arrow-ipc-read-write-test`: 409/410 passed (1 pre-existing
failure due to missing `ARROW_TEST_DATA`)
### Are there any user-facing changes?
No. These are internal APIs so no compatibility changes are needed.
Closes #50237
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
