rok commented on code in PR #50203:
URL: https://github.com/apache/arrow/pull/50203#discussion_r3468533086
##########
python/pyarrow/src/arrow/python/python_to_arrow.cc:
##########
@@ -908,13 +908,33 @@ class PyListConverter : public ListConverter<T,
PyConverter, PyConverterTrait> {
Status AppendNdarray(PyObject* value) {
PyArrayObject* ndarray = reinterpret_cast<PyArrayObject*>(value);
- if (PyArray_NDIM(ndarray) != 1) {
- return Status::Invalid("Can only convert 1-dimensional array values");
- }
if (PyArray_ISBYTESWAPPED(ndarray)) {
// TODO
return Status::NotImplemented("Byte-swapped arrays not supported");
}
+ OwnedRef flattened;
+ if (PyArray_NDIM(ndarray) != 1) {
+ // GH-49644: variable-sized lists only accept 1-dimensional values, and
+ // 0-dimensional arrays are still rejected.
+ if (PyArray_NDIM(ndarray) < 2) {
+ return Status::Invalid("Can only convert 1-dimensional array values");
+ }
Review Comment:
Scratch that it should work. The old implementation was blocking `ndim == 0`
cases, but it probably shouldn't.
##########
python/pyarrow/src/arrow/python/python_to_arrow.cc:
##########
@@ -908,13 +908,33 @@ class PyListConverter : public ListConverter<T,
PyConverter, PyConverterTrait> {
Status AppendNdarray(PyObject* value) {
PyArrayObject* ndarray = reinterpret_cast<PyArrayObject*>(value);
- if (PyArray_NDIM(ndarray) != 1) {
- return Status::Invalid("Can only convert 1-dimensional array values");
- }
if (PyArray_ISBYTESWAPPED(ndarray)) {
// TODO
return Status::NotImplemented("Byte-swapped arrays not supported");
}
+ OwnedRef flattened;
+ if (PyArray_NDIM(ndarray) != 1) {
+ // GH-49644: variable-sized lists only accept 1-dimensional values, and
+ // 0-dimensional arrays are still rejected.
+ if (PyArray_NDIM(ndarray) < 2) {
+ return Status::Invalid("Can only convert 1-dimensional array values");
+ }
Review Comment:
Ah wait we still have `this->list_type_->id() == Type::FIXED_SIZE_LIST`
cases here. Will add suggestion below.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
