Rich-T-kid commented on code in PR #10137:
URL: https://github.com/apache/arrow-rs/pull/10137#discussion_r3469890603
##########
arrow-flight/src/encode.rs:
##########
@@ -159,16 +159,12 @@ pub struct FlightDataEncoderBuilder {
dictionary_handling: DictionaryHandling,
}
-/// Default target size for encoded [`FlightData`].
-///
-/// Note this value would normally be 4MB, but the size calculation is
-/// somewhat inexact, so we set it to 2MB.
-pub const GRPC_TARGET_MAX_FLIGHT_SIZE_BYTES: usize = 2097152;
-
impl Default for FlightDataEncoderBuilder {
fn default() -> Self {
Self {
- max_flight_data_size: GRPC_TARGET_MAX_FLIGHT_SIZE_BYTES,
+ // Default target size for encoded FlightData. gRPC has a default
max message
+ // size of 3MB; we use 3MB so batches are split to stay within
that limit.
+ max_flight_data_size: 3 * 1024 * 1024,
Review Comment:
re-introduce this as a constant, removing it would be a breaking change.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
