HuaHuaY commented on code in PR #50160:
URL: https://github.com/apache/arrow/pull/50160#discussion_r3473607571
##########
cpp/src/parquet/arrow/path_internal.cc:
##########
@@ -387,17 +387,16 @@ class ListPathNode {
PathWriteContext* context) {
// First fill int the remainder of the list.
RETURN_IF_ERROR(FillRepLevels(child_range->Size(), rep_level_, context));
+
// Once we've reached this point the following preconditions should hold:
// 1. There are no more repeated path nodes to deal with.
- // 2. All elements in |range| represent contiguous elements in the
- // child array (Null values would have shortened the range to ensure
- // all remaining list elements are present (though they may be empty
lists)).
+ // 2. Null values would have shortened the range to ensure all remaining
+ // list elements are present (though they may be empty lists).
// 3. No element of range spans a parent list (intermediate
// list nodes only handle one list entry at a time).
//
- // Given these preconditions it should be safe to fill runs on non-empty
+ // Given these preconditions it is safe to fill runs on contiguous
non-empty
// lists here and expand the range in the child node accordingly.
-
while (!range->Empty()) {
ElementRange size_check = selector_.GetRange(range->start);
Review Comment:
Yes. I have renamed it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
