klion26 commented on PR #10157: URL: https://github.com/apache/arrow-rs/pull/10157#issuecomment-4798902017
I've update the code, - changed the `Variant::as_xx` as identity function - removed `Variant::as_f16`, -- will always return None for `as_f16` if we keep it. but don't remove the `Variant::as_u8/16/32/64` for now, we use `Variant::as_xx` in the `shred` logic, but `Variant::as_xx` _is not for shred use only_, so I don't remove them for now, `Variant::as_u8` returns Some(v) for `Variant::Int8` but None for other variants. I can remove them if reached to a consensuse that we want to remove `Variant::as_u8/16/32/64` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
