fenfeng9 commented on PR #50166: URL: https://github.com/apache/arrow/pull/50166#issuecomment-4799442260
> Well, allowing null variadic buffers inside Arrow C++ might lead to hidden issues if we dereference them. Perhaps it's better to normalize null variadic buffers when importing them over the C Data Interface. It looks like the import path already handles null buffers — when the data pointer is null and size is 0, it gets normalized to `zero_size_buffer_`. `Status ImportBinaryView(const BinaryViewType&)`: https://github.com/apache/arrow/blob/445851a3b3b22891977ac1a8b5ceabf42e6bbf52/cpp/src/arrow/c/bridge.cc#L1767-L1774 `ImportBuffer`: https://github.com/apache/arrow/blob/445851a3b3b22891977ac1a8b5ceabf42e6bbf52/cpp/src/arrow/c/bridge.cc#L1912-L1935 https://github.com/apache/arrow/blob/445851a3b3b22891977ac1a8b5ceabf42e6bbf52/cpp/src/arrow/c/bridge.cc#L1944-L1947 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
