zhuqi-lucas commented on PR #10158: URL: https://github.com/apache/arrow-rs/pull/10158#issuecomment-4815750465
> Thank you @zhuqi-lucas -- I have thought more about this PR and API and the more I think about it the more I think it would be better if we just went with the clone of the selection approach initially > > I made a PR to update this PR with the proposal, for your consideration > > * [zhuqi-lucas#4](https://github.com/zhuqi-lucas/arrow-rs/pull/4) > > What I suggest we do is: > > 1. Simplify this PR and merge in the inefficient implementation > 2. Work on some ways to improve the implementation's performance as a follow on / when we have additional evidence that the `peek_next_row_group` is too slow > > Some other ideas about improving the performance without a second copy of the code: > > 1. Maybe we can split the "decide how to advance the selection / row group" logic from the "actually mutate the state" - then we would call the decision logic in peek_next_row_group 🤔 Thank you @alamb , i approved the [zhuqi-lucas#4](https://github.com/zhuqi-lucas/arrow-rs/pull/4) , but i have no permission to merge it. I agree we can optimize performance as a folllow up. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
