Jefffrey commented on code in PR #10221:
URL: https://github.com/apache/arrow-rs/pull/10221#discussion_r3486815818
##########
arrow-ipc/src/compression.rs:
##########
@@ -28,12 +28,14 @@ const LENGTH_OF_PREFIX_DATA: i64 = 8;
/// compression calls to avoid the performance overhead of initialising a new
context for every
/// compression.
#[derive(Default)]
-pub struct CompressionContext {
+pub struct IpcWriteContext {
+ #[allow(dead_code)]
Review Comment:
```suggestion
#[expect(dead_code)]
```
##########
arrow-ipc/src/compression.rs:
##########
@@ -57,6 +59,10 @@ impl std::fmt::Debug for CompressionContext {
}
}
+/// Deprecated alias for [`IpcWriteContext`].
+#[deprecated(since = "57.0.0", note = "Use IpcWriteContext instead")]
Review Comment:
```suggestion
#[deprecated(since = "59.1.0", note = "Use IpcWriteContext instead")]
```
##########
arrow-ipc/src/writer.rs:
##########
@@ -43,7 +43,8 @@ use arrow_schema::*;
use crate::CONTINUATION_MARKER;
use crate::compression::CompressionCodec;
-pub use crate::compression::CompressionContext;
+#[allow(deprecated)]
Review Comment:
```suggestion
#[expect(deprecated)]
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
