Copilot commented on code in PR #60:
URL: https://github.com/apache/arrow-erlang/pull/60#discussion_r3487699781
##########
.github/workflows/rust-ci.yml:
##########
@@ -89,12 +89,12 @@ jobs:
steps:
- uses: actions/checkout@v3
- - uses: dtolnay/rust-toolchain@master
+ - uses: dtolnay/rust-toolchain@29eef336d9b2848a0b548edc03f92a220660cdb8
# v1
with:
toolchain: "${{ env.RUST_TOOLCHAIN_VERSION }}"
components: rustfmt
- - uses: Swatinem/rust-cache@v2
+ - uses: swatinem/rust-cache@v2 # v2.9.1
Review Comment:
`swatinem/rust-cache@v2` is a moving major tag, but the inline comment
claims `v2.9.1`. This is misleading and also makes the workflow less
reproducible than the lint job which pins the action to the `v2.9.1` commit SHA.
##########
.github/workflows/rust-ci.yml:
##########
@@ -64,12 +64,12 @@ jobs:
steps:
- uses: actions/checkout@v3
- - uses: dtolnay/rust-toolchain@master
+ - uses: dtolnay/rust-toolchain@29eef336d9b2848a0b548edc03f92a220660cdb8
# v1
with:
toolchain: "${{ env.RUST_TOOLCHAIN_VERSION }}"
components: rustfmt
- - uses: Swatinem/rust-cache@v2
+ - uses: swatinem/rust-cache@v2 # v2.9.1
Review Comment:
`swatinem/rust-cache@v2` is a moving major tag, but the inline comment
claims `v2.9.1`. This is misleading and also makes the workflow less
reproducible than the lint job which pins the action to the `v2.9.1` commit SHA.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
