jonkeane commented on code in PR #49553:
URL: https://github.com/apache/arrow/pull/49553#discussion_r3487856362
##########
r/tools/nixlibs.R:
##########
@@ -942,16 +953,22 @@ with_cloud_support <- function(env_var_list) {
print_warning("requires libcurl-devel (rpm) or libcurl4-openssl-dev
(deb)")
arrow_s3 <- FALSE
arrow_gcs <- FALSE
+ arrow_azure <- FALSE
} else if (!cmake_find_package("OpenSSL", "1.0.2", env_var_list)) {
print_warning("requires version >= 1.0.2 of openssl-devel (rpm),
libssl-dev (deb), or openssl (brew)")
arrow_s3 <- FALSE
arrow_gcs <- FALSE
+ arrow_azure <- FALSE
+ } else if (!cmake_find_package("libxml2", NULL, env_var_list)) {
+ print_warning("requires libxml2-devel (rpm), or libxml2-dev (deb),
libxml2 (brew)", "AZURE")
+ arrow_azure <- FALSE
}
Review Comment:
If I'm following correctly, this check will run regardless of if someone is
trying to setup Azure. Is it possible to make this only run if someone has
requested Azure?
##########
r/configure.win:
##########
@@ -67,6 +67,7 @@ function configure_binaries() {
# pkg-config --libs libcurl
GCS_LIBS="-lcurl -lnormaliz -lssh2 -lgdi32 -lssl -lcrypto -lcrypt32
-lwldap32 \
-lz -lws2_32 -lnghttp2 -ldbghelp"
+ # AZURE_LIBS="-lcurl -lssl -lxml2"
Review Comment:
These are holdovers from when you were trying these on Windows, yeah?
##########
r/tools/nixlibs.R:
##########
@@ -942,16 +953,22 @@ with_cloud_support <- function(env_var_list) {
print_warning("requires libcurl-devel (rpm) or libcurl4-openssl-dev
(deb)")
arrow_s3 <- FALSE
arrow_gcs <- FALSE
+ arrow_azure <- FALSE
Review Comment:
Is libcurl and openssl necessary for Azure as well? These additions seem to
indicate yes, but I want to confirm that
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
