pchintar commented on PR #9991: URL: https://github.com/apache/arrow-rs/pull/9991#issuecomment-4826112513
Thnx @Jefffrey for the review! I've addressed your comments: * Added a unit test to exercise both the bounded heap path and the existing partial-sort path. * Updated the branch selection logic to only use the heap path when a limit is specified. * Removed the unreachable full-sort branch from `lexsort_topk`. * Removed the temporary tie-breaking comparator used during earlier investigation. For the branch selection, I initially tried your suggested `if let` form, but it failed the MSRV check since `if let` chains aren't supported by Rust 1.85. So, I replaced it with an equivalent `match` expression to keep the same behavior while remaining MSRV-compatible. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
