shrivasshankar commented on code in PR #50198:
URL: https://github.com/apache/arrow/pull/50198#discussion_r3488573965
##########
cpp/src/arrow/compute/kernels/scalar_arithmetic.cc:
##########
@@ -368,6 +368,15 @@ struct Atan2 {
}
};
+struct Hypot {
+ template <typename T, typename Arg0, typename Arg1>
+ static enable_if_floating_value<Arg0, T> Call(KernelContext*, Arg0 x, Arg1
y, Status*) {
+ static_assert(std::is_same<T, Arg0>::value, "");
+ static_assert(std::is_same<Arg0, Arg1>::value, "");
Review Comment:
good point, i dropped the second one the binary kernel dispatch already
guarantees both args are the same type. I kept the T == Arg0 one.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
