pitrou commented on code in PR #48180:
URL: https://github.com/apache/arrow/pull/48180#discussion_r3490360525
##########
cpp/src/arrow/compute/util.cc:
##########
@@ -104,6 +104,9 @@ void bits_to_indexes_internal(int64_t hardware_flags, const
int num_bits,
*num_indexes = 0;
for (int i = 0; i < num_bits / unroll; ++i) {
uint64_t word = util::SafeLoad(&reinterpret_cast<const
uint64_t*>(bits)[i]);
+#if !ARROW_LITTLE_ENDIAN
+ word = ::arrow::bit_util::ByteSwap(word);
+#endif
Review Comment:
Please use `FromLittleEndian` instead of adding `#if`s everywhere.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
