rok commented on code in PR #50278:
URL: https://github.com/apache/arrow/pull/50278#discussion_r3491330661


##########
python/pyarrow/tests/test_memory.py:
##########
@@ -38,9 +38,10 @@ def backend_factory(backend_name):
 
 
 def supported_factories():
-    yield pa.default_memory_pool
+    factories = [pa.default_memory_pool]
     for backend_name in pa.supported_memory_backends():
-        yield backend_factory(backend_name)
+        factories.append(backend_factory(backend_name))
+    return factories

Review Comment:
   Ah, my search didn't show the second one.
   Could do a list comprehension at least so this doesn't look so complicated? 
Also ok if not.
   
   ```python
   def supported_factories():
       factories = [pa.default_memory_pool]
       retrun factories + [backend_factory(bn) for bn in 
pa.supported_memory_backends()]
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to