Copilot commented on code in PR #50296:
URL: https://github.com/apache/arrow/pull/50296#discussion_r3497108470
##########
cpp/src/arrow/util/ulp_distance.cc:
##########
@@ -50,7 +50,7 @@ struct FloatToUInt<util::Float16> {
template <typename Float>
struct UlpDistanceUtil {
public:
- using UIntType = FloatToUInt<Float>::Type;
+ using UIntType = typename FloatToUInt<Float>::Type;
Review Comment:
The PR title/description indicate this is only a clang-15 fix for missing
`typename` in ulp_distance.cc, but the diff also includes substantial R and
Python changes (string_view/binary_view support and new tests) plus converter
updates. Please update the PR title/description to reflect the broader scope,
or split into focused PRs to make review/rollback safer.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
