kdn36 commented on PR #728: URL: https://github.com/apache/arrow-rs-object-store/pull/728#issuecomment-4842427608
Apologies for the delay. The custom client `HttpConnector` trait has the `connect(&self, options: &ClientOptions)` method, yet the fields of `ClientOptions` are not public. So to implement the trait and honor the options (which object_store may set or modify), one would have to extract them one by one and reapply. Technically not impossible, but error-prone and difficult to maintain. Unless I am missing something. Object_store having its own `Resolve` trait (details to be worked out) should be viable and would enable object_store not to leak implementation details. This is something I can look into. At first glance, this would be the cleanest way forward for our use case. Fwiw, the code in the PR is in use already with a lightweight shuffling cache and works as expected. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
