alamb commented on code in PR #10229:
URL: https://github.com/apache/arrow-rs/pull/10229#discussion_r3498685083
##########
arrow-row/src/fixed.rs:
##########
@@ -469,9 +422,20 @@ where
T::Native: FixedLengthEncoding,
{
assert!(PrimitiveArray::<T>::is_compatible(&data_type));
- // SAFETY:
- // Validated data type above
- unsafe { decode_fixed::<T::Native>(rows, data_type, options).into() }
+
+ let len = rows.len();
+
+ let mut values = BufferBuilder::<T::Native>::new(len);
Review Comment:
> locally i seem to get some nice speedups from switching to vec:
Yeah, the Rust team has optimized Vec *a lot*
> i wonder if we should also look for usages of [offset]bufferbuilder and
replace them, like we're doing for arraydata 🤔
Yes, I think that would be a nice idea. I filed a ticket
- https://github.com/apache/arrow-rs/issues/10245
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
