fallintoplace opened a new pull request, #871:
URL: https://github.com/apache/arrow-go/pull/871

   ### What changed
   
   Dictionary concatenation now converts the element position to a byte offset 
before zeroing null index runs in concatDictIndices.
   
   ### Why
   
   concatDictIndices tracks pos in elements, but the null-run branch used it as 
a byte offset. For dictionary index widths larger than one byte, that could 
zero the wrong byte range, corrupting adjacent valid indices while leaving the 
null slot's bytes stale.
   
   ### Validation
   
   - go test ./arrow/array -run 
TestConcatDictionaryNullIndexRunsPreserveWideIndices -count=1
   - go test ./arrow/array -count=1
   - PARQUET_TEST_DATA=/Users/hoangvu/Code/OSS/arrow-go/parquet-testing/data 
ARROW_TEST_DATA=/Users/hoangvu/Code/OSS/arrow-go/arrow-testing/data go test 
./... -count=1


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to