Copilot commented on code in PR #50288:
URL: https://github.com/apache/arrow/pull/50288#discussion_r3503563787
##########
dev/tasks/linux-packages/apache-arrow/yum/arrow.spec.in:
##########
@@ -482,11 +484,45 @@ Libraries and header files for Apache Arrow Flight SQL.
%doc README.md
%license LICENSE.txt NOTICE.txt
%{_includedir}/arrow/flight/sql/
+%exclude %{_includedir}/arrow/flight/sql/odbc/
%{_libdir}/cmake/ArrowFlightSql/
%{_libdir}/libarrow_flight_sql.a
%{_libdir}/libarrow_flight_sql.so
%{_libdir}/pkgconfig/arrow-flight-sql.pc
+%package -n %{name}%{so_version}-flight-sql-odbc-libs
+Summary: C++ library for interacting with SQL databases via ODBC.
+License: Apache-2.0
+Requires: %{name}%{so_version}-flight-sql-libs = %{version}-%{release}
+
+%description -n %{name}%{so_version}-flight-sql-odbc-libs
+This package contains the libraries for Apache Arrow Flight SQL ODBC driver.
+
+%files -n %{name}%{so_version}-flight-sql-odbc-libs
+%defattr(-,root,root,-)
+%doc README.md
+%license LICENSE.txt NOTICE.txt
+%{_libdir}/libarrow_flight_sql_odbc.so.*
+
+%package flight-sql-odbc-devel
+Summary: Libraries and header files for Apache Arrow Flight SQL ODBC
driver.
+License: Apache-2.0
+Requires: %{name}%{so_version}-flight-sql-odbc-libs =
%{version}-%{release}
+Requires: %{name}-flight-sql-devel = %{version}-%{release}
+
Review Comment:
The new `flight-sql-odbc-devel` package ships headers under
`arrow/flight/sql/odbc/` (installed via
`arrow_install_all_headers("arrow/flight/sql/odbc")` in
`cpp/src/arrow/flight/sql/odbc/CMakeLists.txt`) and those headers include ODBC
headers (e.g. `<sql.h>`, `<sqlext.h>`). Without an explicit dependency, users
can install the `-devel` RPM but still be missing the unixODBC headers needed
to compile against it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
