AlenkaF commented on code in PR #41870:
URL: https://github.com/apache/arrow/pull/41870#discussion_r3504141315
##########
cpp/src/arrow/tensor.h:
##########
@@ -77,6 +77,10 @@ Status ValidateTensorParameters(const
std::shared_ptr<DataType>& type,
const std::vector<int64_t>& strides,
const std::vector<std::string>& dim_names);
+ARROW_EXPORT
+Status TableToTensor(const Table& table, bool null_to_nan, bool row_major,
+ MemoryPool* pool, std::shared_ptr<Tensor>* tensor);
Review Comment:
Ignoring.
##########
cpp/src/arrow/tensor.cc:
##########
@@ -256,26 +263,36 @@ struct ConvertColumnsToTensorVisitor {
};
template <typename Out>
-struct ConvertColumnsToTensorRowMajorVisitor {
+struct ConvertArrayToTensorRowMajorVisitor {
Out*& out_values;
const ArrayData& in_data;
- int num_cols;
- int col_idx;
+ int64_t num_cols;
+ int64_t col_idx;
+ int64_t chunk_idx;
Review Comment:
Ignoring.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
