alamb commented on code in PR #9865:
URL: https://github.com/apache/arrow-rs/pull/9865#discussion_r3508054084
##########
arrow-select/Cargo.toml:
##########
@@ -40,8 +40,15 @@ arrow-buffer = { workspace = true }
arrow-data = { workspace = true }
arrow-schema = { workspace = true }
arrow-array = { workspace = true }
+arrow-ord-basic = { workspace = true, optional = true }
num-traits = { version = "0.2.19", default-features = false, features =
["std"] }
ahash = { version = "0.8", default-features = false}
+[features]
+# Enables the run-end-encoded `take` fast path that merges adjacent
+# physical indices whose underlying values compare equal. Pulls in
+# `arrow-ord-basic` for the slot-wise comparator.
+run_end_encoded = ["dep:arrow-ord-basic"]
Review Comment:
As long as it isn't a lot of code, I think including it always is fine
In this case I think it will be unlikely that anyone will use these features
/ disable them, so just keeping the code simpler sounds like a good idea
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
