amoeba commented on PR #50324:
URL: https://github.com/apache/arrow/pull/50324#issuecomment-4859331266
Hey @OmBiradar, thanks for the PR. The patch looks good.
Before we approve and merge, could you make some changes to the issue title
and PR title to help maintainers and future contributors out?
- I already changed the PR title a bit:
- I changed [DOCS] to [Docs] just to match the style used in other PRs.
Using existing issues and PRs as a guide for new ones is often a good idea.
- I removed the [MINOR] tag since we don't use that tag when the PR has an
associated issue. Filing an issue like you did is always a good step if you
aren't sure but, now that you have some more experience, changes like this are
fine as minor PRs and filing an issue first isn't required.
- I added [C++] since it helps to clarify this Docs change is to the C++
docs.
- Can you improve the wording of the PR title? "Fix the docs of
arrow::MemoryManager" isn't specific enough. PR titles will show up in the git
blame so something specific would be better. For example, "Remove misplaced
sentence fragment in memory.rst"
- Can you improve the issue title? Something more specific (like above)
would be good.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
