Jefffrey commented on code in PR #10259:
URL: https://github.com/apache/arrow-rs/pull/10259#discussion_r3509725836
##########
arrow/benches/row_format.rs:
##########
@@ -61,6 +61,25 @@ fn do_bench(c: &mut Criterion, name: &str, cols:
Vec<ArrayRef>) {
b.iter(|| hint::black_box(converter.convert_rows(&rows).unwrap()));
});
+ let binary_rows = rows.clone().try_into_binary().expect("reasonable size");
+ let parser = converter.parser();
+ // RowParser marks rows as requiring UTF-8 validation when they are decoded
+ // back into Arrow arrays by RowConverter::convert_rows.
+ let parsed_rows: Vec<_> = binary_rows
+ .iter()
+ .flatten()
Review Comment:
does this mean nulls are ignored in this bench?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
