Copilot commented on code in PR #50328:
URL: https://github.com/apache/arrow/pull/50328#discussion_r3510023042
##########
ci/scripts/r_install_system_dependencies.sh:
##########
@@ -38,10 +38,11 @@ fi
# Install curl, OpenSSL, and libuv
# - curl/OpenSSL: technically only needed for S3/GCS support, but
# installing the R curl package fails without it
+# - libpng: required by the png R package
# - libuv: required by the fs R package (no longer bundles libuv by default)
case "$PACKAGE_MANAGER" in
apt-get)
- apt-get install -y libcurl4-openssl-dev libssl-dev libuv1-dev
+ apt-get install -y libcurl4-openssl-dev libpng-dev libssl-dev libuv1-dev
;;
apk)
$PACKAGE_MANAGER add curl-dev openssl-dev libuv-dev
Review Comment:
`libpng` is documented here as a required system dependency, but it is only
installed for the `apt-get` branch. Since this script is also executed in the
Alpine R image (`apk`), consider adding `libpng-dev` there as well so the
dependency set stays consistent across CI images that share this script.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
