adamreeve commented on code in PR #379:
URL: https://github.com/apache/arrow-dotnet/pull/379#discussion_r3509994825
##########
Apache.Arrow.sln:
##########
@@ -264,10 +275,51 @@ Global
{73EBE132-AE05-4C32-9525-515F4768156B}.Release|x64.Build.0 =
Release|Any CPU
{73EBE132-AE05-4C32-9525-515F4768156B}.Release|x86.ActiveCfg =
Release|Any CPU
{73EBE132-AE05-4C32-9525-515F4768156B}.Release|x86.Build.0 =
Release|Any CPU
+ {3F9AEB1B-814A-4B82-8E0A-481AEA0CBDD0}.Debug|Any CPU.ActiveCfg
= Debug|Any CPU
+ {3F9AEB1B-814A-4B82-8E0A-481AEA0CBDD0}.Debug|Any CPU.Build.0 =
Debug|Any CPU
+ {3F9AEB1B-814A-4B82-8E0A-481AEA0CBDD0}.Debug|x64.ActiveCfg =
Debug|Any CPU
+ {3F9AEB1B-814A-4B82-8E0A-481AEA0CBDD0}.Debug|x64.Build.0 =
Debug|Any CPU
+ {3F9AEB1B-814A-4B82-8E0A-481AEA0CBDD0}.Debug|x86.ActiveCfg =
Debug|Any CPU
+ {3F9AEB1B-814A-4B82-8E0A-481AEA0CBDD0}.Debug|x86.Build.0 =
Debug|Any CPU
+ {3F9AEB1B-814A-4B82-8E0A-481AEA0CBDD0}.Release|Any
CPU.ActiveCfg = Release|Any CPU
+ {3F9AEB1B-814A-4B82-8E0A-481AEA0CBDD0}.Release|Any CPU.Build.0
= Release|Any CPU
+ {3F9AEB1B-814A-4B82-8E0A-481AEA0CBDD0}.Release|x64.ActiveCfg =
Release|Any CPU
+ {3F9AEB1B-814A-4B82-8E0A-481AEA0CBDD0}.Release|x64.Build.0 =
Release|Any CPU
+ {3F9AEB1B-814A-4B82-8E0A-481AEA0CBDD0}.Release|x86.ActiveCfg =
Release|Any CPU
+ {3F9AEB1B-814A-4B82-8E0A-481AEA0CBDD0}.Release|x86.Build.0 =
Release|Any CPU
+ {E183F970-90FA-49F1-B339-7827171A3B02}.Debug|Any CPU.ActiveCfg
= Debug|Any CPU
+ {E183F970-90FA-49F1-B339-7827171A3B02}.Debug|Any CPU.Build.0 =
Debug|Any CPU
+ {E183F970-90FA-49F1-B339-7827171A3B02}.Debug|x64.ActiveCfg =
Debug|Any CPU
+ {E183F970-90FA-49F1-B339-7827171A3B02}.Debug|x64.Build.0 =
Debug|Any CPU
+ {E183F970-90FA-49F1-B339-7827171A3B02}.Debug|x86.ActiveCfg =
Debug|Any CPU
+ {E183F970-90FA-49F1-B339-7827171A3B02}.Debug|x86.Build.0 =
Debug|Any CPU
+ {E183F970-90FA-49F1-B339-7827171A3B02}.Release|Any
CPU.ActiveCfg = Release|Any CPU
+ {E183F970-90FA-49F1-B339-7827171A3B02}.Release|Any CPU.Build.0
= Release|Any CPU
+ {E183F970-90FA-49F1-B339-7827171A3B02}.Release|x64.ActiveCfg =
Release|Any CPU
+ {E183F970-90FA-49F1-B339-7827171A3B02}.Release|x64.Build.0 =
Release|Any CPU
+ {E183F970-90FA-49F1-B339-7827171A3B02}.Release|x86.ActiveCfg =
Release|Any CPU
+ {E183F970-90FA-49F1-B339-7827171A3B02}.Release|x86.Build.0 =
Release|Any CPU
+ {C9657321-6DFA-411A-AD42-D51C51D0FAF0}.Debug|Any CPU.ActiveCfg
= Debug|Any CPU
+ {C9657321-6DFA-411A-AD42-D51C51D0FAF0}.Debug|Any CPU.Build.0 =
Debug|Any CPU
+ {C9657321-6DFA-411A-AD42-D51C51D0FAF0}.Debug|x64.ActiveCfg =
Debug|Any CPU
+ {C9657321-6DFA-411A-AD42-D51C51D0FAF0}.Debug|x64.Build.0 =
Debug|Any CPU
+ {C9657321-6DFA-411A-AD42-D51C51D0FAF0}.Debug|x86.ActiveCfg =
Debug|Any CPU
+ {C9657321-6DFA-411A-AD42-D51C51D0FAF0}.Debug|x86.Build.0 =
Debug|Any CPU
+ {C9657321-6DFA-411A-AD42-D51C51D0FAF0}.Release|Any
CPU.ActiveCfg = Release|Any CPU
+ {C9657321-6DFA-411A-AD42-D51C51D0FAF0}.Release|Any CPU.Build.0
= Release|Any CPU
+ {C9657321-6DFA-411A-AD42-D51C51D0FAF0}.Release|x64.ActiveCfg =
Release|Any CPU
+ {C9657321-6DFA-411A-AD42-D51C51D0FAF0}.Release|x64.Build.0 =
Release|Any CPU
+ {C9657321-6DFA-411A-AD42-D51C51D0FAF0}.Release|x86.ActiveCfg =
Release|Any CPU
+ {C9657321-6DFA-411A-AD42-D51C51D0FAF0}.Release|x86.Build.0 =
Release|Any CPU
EndGlobalSection
GlobalSection(SolutionProperties) = preSolution
HideSolutionNode = FALSE
EndGlobalSection
+ GlobalSection(NestedProjects) = preSolution
Review Comment:
This nests the new projects under "src" and "test" folders, but no other
projects are nested like this. Can you either remove the nesting or make other
projects also nested for consistency.
I like the nesting and it matches the directory layout so my preference
would be to also nest the others.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
