Rich-T-kid commented on PR #10260: URL: https://github.com/apache/arrow-rs/pull/10260#issuecomment-4861761466
Two approaches are split between the two commits [commit #1](https://github.com/apache/arrow-rs/pull/10260/changes/e8110ec460fa0c1ea5dd00bfdd086e20b0719e83): Introduce a new struct that holds `metadata_version` as well as the `unsafeFlag`. pass this to `arrow-ipc::reader::read_dictionary()`. **this would be a breaking API change** [commit #2](https://github.com/apache/arrow-rs/pull/10260/changes/82fd3b896620c9a418dd0509e35f46346cfbe7d0): expose ` arrow_ipc::reader::read_dictionary_impl` directly so that the unsafe flag can be called directly. **this is not a breaking API change** I'm happy to go with either approach depending on what the maintainers think is more appropriate. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
