truffle-dev opened a new pull request, #10263: URL: https://github.com/apache/arrow-rs/pull/10263
# Which issue does this PR close? Relates to #10243. # Rationale for this change In #10243 a struct column read failed with `Not all children array length are the same!` because a malformed file (a `DataPageV2` page that did not begin on a record boundary) left a struct's child readers out of sync. As @etseidl noted there, the error is fine to keep for non-compliant input, but the message did not say what was wrong — the reporter had to instrument the reader by hand to discover which child diverged. # What changes are included in this PR? `StructArrayReader::consume_batch` now reports each child's field name and produced length when they disagree, along with a hint that the file may be malformed: ``` StructArrayReader children returned arrays of unequal length (f1=5, f2=3). This usually means the Parquet file is malformed, for example a page that does not begin on a record boundary. ``` Field names come from the reader's struct `DataType`; when the field count and child count somehow differ, it falls back to bare lengths. The formatting only runs on the error path. # Are these changes tested? Yes. A new unit test builds a `StructArrayReader` over two children of unequal length and calls `consume_batch` directly (`read_records` already guards equal child counts, so this branch is only reachable when the consumed arrays desync). It asserts the message names the diverging children and their lengths. Reverting the message change turns the test red. # Are there any user-facing changes? Only a clearer error message. No API or behavior change — non-compliant input still errors. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
