Copilot commented on code in PR #50317:
URL: https://github.com/apache/arrow/pull/50317#discussion_r3520253946
##########
r/inst/build_arrow_static.sh:
##########
@@ -114,7 +114,7 @@ ${CMAKE_WRAPPER} ${CMAKE} -DARROW_BOOST_USE_SHARED=OFF \
-G "${CMAKE_GENERATOR:-Unix Makefiles}" \
${SOURCE_DIR}
-${CMAKE} --build . --target install -- -j $N_JOBS
+MAKEFLAGS="${MAKEFLAGS/-jNA/}" ${CMAKE} --build . --target install -- -j
$N_JOBS
Review Comment:
The change only strips the literal substring "-jNA" from MAKEFLAGS, but the
intent (and PR title) is to unset MAKEFLAGS for this nested build. This is
brittle (won’t handle cases like "-j NA", "-j", or other invalid/non-numeric -j
values) and could leave other MAKEFLAGS options that still influence the nested
make invocation. Prefer clearing/unsetting MAKEFLAGS for the build command so
the explicit "-- -j $N_JOBS" is the single source of parallelism.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
