fallintoplace commented on PR #896: URL: https://github.com/apache/arrow-go/pull/896#issuecomment-4880017497
## Improved summary - Fix scope: multiBufferBuilder.UnsafeAppend now validates that a value copy completed fully before proceeding. - Behavior change: if copy writes fewer bytes than the requested value length, we now fail fast (panic) instead of silently keeping a truncated value with inconsistent view metadata. - Why this matters: avoids silent data corruption in BinaryViewBuilder/StringViewBuilder out-of-line payloads where headers can reference bytes that were never written. - Coverage: added TestMultiBufferBuilderUnsafeAppendPanicsOnTruncatedCopy to lock this regression. - Risk: scoped change, and fail-fast here is preferable to corrupted output. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
