eitsupi commented on code in PR #4455:
URL: https://github.com/apache/arrow-adbc/pull/4455#discussion_r3525798948
##########
.github/workflows/rust.yml:
##########
@@ -244,7 +227,7 @@ jobs:
-p arrow-schema \
-p arrow-select
- # If the lock file was updated, run the tests except for
adbc_datafusion
+ # If the lock file was updated, run the tests
if ! git diff --quiet Cargo.lock; then
- cargo test --all-targets --all-features --workspace --exclude
adbc_datafusion
+ cargo test --all-targets --all-features --workspace
fi
Review Comment:
Of course, there's still the advantage of testing for the latest arrow
immediately before Dependabot updating the lock file, so it might be worth
keeping (although it could be annoying if it suddenly starts failing).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
