Jefffrey commented on code in PR #10292:
URL: https://github.com/apache/arrow-rs/pull/10292#discussion_r3526909107
##########
arrow-buffer/src/buffer/run.rs:
##########
@@ -277,9 +277,32 @@ where
logical_offset.saturating_add(logical_length) <=
self.logical_length,
"the length + offset of the sliced RunEndBuffer cannot exceed the
existing length"
);
- Self {
+ let logical_offset = self.logical_offset + logical_offset;
Review Comment:
cc @Rich-T-kid this is what i was thinking on my previous comments on your PR
essentially we can still reduce how many physical values we hold on to,
without needing to readjust all of the values (still keeping it zero-copy)
we'd need to extend it to runarray too since need to ensure the values array
is similarly compacted (might need a bit of plumbing to make it work) and as
noted in the issue callsites may need to be adjusted
lemme know your thoughts
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
