raulcd commented on code in PR #45998:
URL: https://github.com/apache/arrow/pull/45998#discussion_r3527532841
##########
cpp/src/arrow/filesystem/hdfs.cc:
##########
@@ -39,28 +38,114 @@ using util::Uri;
namespace fs {
+#define CHECK_FAILURE(RETURN_VALUE, WHAT) \
+ do { \
+ if (RETURN_VALUE == -1) { \
+ return IOErrorFromErrno(errno, "HDFS ", WHAT, " failed"); \
+ } \
+ } while (0)
+
+static constexpr int kDefaultHdfsBufferSize = 1 << 16;
Review Comment:
this seems to be copied from `cpp/src/arrow/io/hdfs.cc`
Do we require code on both filesystem and io? Should we have a common place
instead of repeating code?Reading the description of the PR I thought we were
completely removing `cpp/src/arrow/io/hdfs.cc` but the file seems to be there.
What is the code that should land here on the other?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
