Copilot commented on code in PR #50386: URL: https://github.com/apache/arrow/pull/50386#discussion_r3527688802
########## ruby/red-arrow-format/lib/arrow-format/bitmap-builder.rb: ########## @@ -0,0 +1,88 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOTICE file +# distributed with this work for additional information +# regarding copyright ownership. The ASF licenses this file +# to you under the Apache License, Version 2.0 (the +# "License"); you may not use this file except in compliance +# with the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, +# software distributed under the License is distributed on an +# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +# KIND, either express or implied. See the License for the +# specific language governing permissions and limitations +# under the License. + +require_relative "buffer-alignable" + +module ArrowFormat + class DenseBitmapBuilder + include BufferAlignable + + def initialize + @buffer = +"".b + @n_bits = 0 + @byte = 0 + end + + def append(value) + @byte |= 1 << @n_bits if value + @n_bits += 1 + flush if @n_bits == 8 + self + end + + def finish + flush if @n_bits > 0 + padding_size = buffer_padding_size(@buffer) + @buffer.append_as_bytes(padding(padding_size)) if padding_size > 0 + @buffer.freeze Review Comment: `String#append_as_bytes` isn't used anywhere else in red-arrow-format and isn't part of Ruby's standard `String` API, so this may raise `NoMethodError` at runtime. Using `String#<<` (or `String#concat`) here would avoid relying on an extra monkey patch while keeping the same behavior. ########## ruby/red-arrow-format/lib/arrow-format/bitmap-builder.rb: ########## @@ -0,0 +1,88 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOTICE file +# distributed with this work for additional information +# regarding copyright ownership. The ASF licenses this file +# to you under the Apache License, Version 2.0 (the +# "License"); you may not use this file except in compliance +# with the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, +# software distributed under the License is distributed on an +# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +# KIND, either express or implied. See the License for the +# specific language governing permissions and limitations +# under the License. + +require_relative "buffer-alignable" + +module ArrowFormat + class DenseBitmapBuilder + include BufferAlignable + + def initialize + @buffer = +"".b + @n_bits = 0 + @byte = 0 + end + + def append(value) + @byte |= 1 << @n_bits if value + @n_bits += 1 + flush if @n_bits == 8 + self + end + + def finish + flush if @n_bits > 0 + padding_size = buffer_padding_size(@buffer) + @buffer.append_as_bytes(padding(padding_size)) if padding_size > 0 + @buffer.freeze + IO::Buffer.for(@buffer) + end + + private + def flush + @buffer.append_as_bytes([@byte].pack("C")) + @n_bits = 0 + @byte = 0 + end + end + + class SparseBitmapBuilder + include BufferAlignable + + def initialize + @unset_indexes = {} + end + + def unset(index) + @unset_indexes[index] = true + end + + def finish(size) + builder = DenseBitmapBuilder.new + set_value = true + unset_value = false + if @unset_indexes.empty? Review Comment: `SparseBitmapBuilder#finish` doesn't validate that all `unset` indexes are within `0...size`. If a caller unsets an index >= size (or a negative index), this will currently append extra bits and return a bitmap longer than the requested size, which will corrupt downstream consumers. ########## ruby/red-arrow-format/lib/arrow-format/bitmap-builder.rb: ########## @@ -0,0 +1,88 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOTICE file +# distributed with this work for additional information +# regarding copyright ownership. The ASF licenses this file +# to you under the Apache License, Version 2.0 (the +# "License"); you may not use this file except in compliance +# with the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, +# software distributed under the License is distributed on an +# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +# KIND, either express or implied. See the License for the +# specific language governing permissions and limitations +# under the License. + +require_relative "buffer-alignable" + +module ArrowFormat + class DenseBitmapBuilder + include BufferAlignable + + def initialize + @buffer = +"".b + @n_bits = 0 + @byte = 0 + end + + def append(value) + @byte |= 1 << @n_bits if value + @n_bits += 1 + flush if @n_bits == 8 + self + end + + def finish + flush if @n_bits > 0 + padding_size = buffer_padding_size(@buffer) + @buffer.append_as_bytes(padding(padding_size)) if padding_size > 0 + @buffer.freeze + IO::Buffer.for(@buffer) + end + + private + def flush + @buffer.append_as_bytes([@byte].pack("C")) + @n_bits = 0 + @byte = 0 + end Review Comment: Same concern as in `finish`: `append_as_bytes` is not referenced anywhere else in this codebase and is not a standard `String` method, so this may fail at runtime. Prefer appending with `<<` to keep the builder self-contained. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
