ByteBaker commented on issue #783:
URL: 
https://github.com/apache/arrow-rs-object-store/issues/783#issuecomment-4895541299

   I'd argue that this is not wrong. As `ClientOptions` has no awareness of the 
impact caused by headers passed by the caller. As such, the string "gzip" does 
not meaning anything to the client, it's just a string, and hence it won't try 
and derive meanings from the payload of default headers, even if one of those 
is "gzip".
   
   However, the right way IMO would be to track encoding inside 
`ClientOptions`, and turn encoding on/off inside the client builder 
accordingly. Since the culprit line `builder = 
builder.no_gzip().no_brotli().no_zstd().no_deflate();` turns off all forms of 
encoding. 
   
   @tustvold @alamb thoughts?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to