pitrou commented on PR #50392:
URL: https://github.com/apache/arrow/pull/50392#issuecomment-4901595101

   > Could you please explain how to interpret this report? It seems to me that 
there are many performance regressions when there are no null values.
   
   The ArrayArrayKernel benchmarks but also the ScalarTemporalBinary benchmarks 
exercise VisitTwoArrayValuesInline. The fact that some show regressions and 
some improvements hints that the compiler is not always able to do a good job 
here.
   
   However, there are also a number of large improvements on the Filter 
benchmarks.
   
   > Incidentally, adding `ARROW_FORCE_INLINE` to `VisitSetBitRuns` provides 
some optimization for `ArrayArrayKernel` in my local environment.
   
   Hmm, I could try it in this PR.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to