Jimexist commented on pull request #275: URL: https://github.com/apache/arrow-rs/pull/275#issuecomment-840549650
> The code itself looks great. > > I am not sure this is not shadowing `PrimitiveArray<T>::from_iter_values`, which IMO covers this exact case. fair point. i've updated the implementation. if this deems unnecessary i'm happy to remove all of the code except for the unit test addition. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
