Copilot commented on code in PR #50401:
URL: https://github.com/apache/arrow/pull/50401#discussion_r3541356012
##########
ruby/red-arrow-flight/test/test-record-batch-reader.rb:
##########
@@ -19,6 +19,7 @@ class TestRecordBatchReader < Test::Unit::TestCase
def setup
@server = nil
omit("Unstable on Windows") if Gem.win_platform?
+ omit("Unstable on macOS") if /darwin/.match?(RUBY_PLATFORM)
@server = Helper::Server.new
Review Comment:
Omitting this test on all macOS platforms removes coverage on ARM64 macOS
and makes it harder to confirm the GC-retention fixes on the platform that’s
currently failing CI. If macOS instability is limited to x86_64 (as in other
tests), keep the omit narrower.
##########
c_glib/test/flight/test-client.rb:
##########
@@ -22,7 +22,7 @@ def setup
@server = nil
omit("Arrow Flight is required") unless defined?(ArrowFlight)
omit("Unstable on Windows") if Gem.win_platform?
- omit("Unstable on x86_64 macOS") if /x86_64-darwin/.match?(RUBY_PLATFORM)
+ omit("Unstable on macOS") if /darwin/.match?(RUBY_PLATFORM)
require_gi_bindings(3, 4, 7)
Review Comment:
This change omits the entire test suite on all macOS platforms, which
significantly reduces coverage (and can mask regressions) on ARM64 macOS where
the GC-related crash is supposed to be validated. Other Flight tests in this
repo typically only omit on x86_64 macOS.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
