lidavidm commented on code in PR #4471: URL: https://github.com/apache/arrow-adbc/pull/4471#discussion_r3541925565
########## c/driver/sqlite/CMakeLists.txt: ########## @@ -27,17 +27,28 @@ else() # vcpkg find_package(unofficial-sqlite3 CONFIG REQUIRED) set(SQLite3_LINK_LIBRARIES unofficial::sqlite3::sqlite3) - set(SQLite3_INCLUDE_DIRS) + get_target_property(SQLite3_INCLUDE_DIRS unofficial::sqlite3::sqlite3 + INTERFACE_INCLUDE_DIRECTORIES) + if(NOT SQLite3_INCLUDE_DIRS) + set(SQLite3_INCLUDE_DIRS) + endif() Review Comment: Does this actually do anything? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
