pitrou commented on code in PR #50269:
URL: https://github.com/apache/arrow/pull/50269#discussion_r3542447258
##########
cpp/src/arrow/util/dict_util_internal.h:
##########
@@ -22,7 +22,25 @@
namespace arrow {
namespace dict_util {
+/// \brief Compute the logical null count of a dictionary-encoded array
+///
+/// This function considers a value to be a logical null if its index is null
or if
+/// it points to a null entry in the dictionary's validity bitmap. This means
that it
+/// only accounts for physical nulls in the dictionary. It does not recurse
into the
+/// dictionary values to find logical nulls, which would matter when those
values are
+/// themselves dictionary, run-end encoded, or union typed.
+ARROW_EXPORT
int64_t LogicalNullCount(const ArraySpan& span);
+/// \brief Populate a bitmap based on the logical nulls in a
dictionary-encoded array
+///
+/// \see LogicalNullCount for how nulls in the dictionary are handled.
+///
+/// \param set_on_null true if we should set bits corresponding to nulls and
false if
+/// we should set bits corresponding to non-nulls
Review Comment:
If you use `\param` then I think you must document all input parameters,
otherwise docs fail building.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
