kszucs commented on a change in pull request #10300:
URL: https://github.com/apache/arrow/pull/10300#discussion_r631813623



##########
File path: dev/tasks/jars/build-cpp-osx.sh
##########
@@ -17,9 +17,11 @@
 # specific language governing permissions and limitations
 # under the License.
 
-set -e
+set -ex

Review comment:
       We maintain the OSX wheel scripts next to the manylinux ones in 
`ci/scripts`. Could you please move this file there as well for consistency?
   
   Something like:
   
   ```
   ci/scripts/java_<whatever>_manylinux_build.sh
   ci/scripts/java_<whatever>_macos_build.sh
   ```




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Reply via email to