Copilot commented on code in PR #100: URL: https://github.com/apache/arrow-erlang/pull/100#discussion_r3545343557
########## .github/pull_request_template.md: ########## @@ -0,0 +1,28 @@ +<!--- + Licensed to the Apache Software Foundation (ASF) under one + or more contributor license agreements. See the NOTICE file + distributed with this work for additional information + regarding copyright ownership. The ASF licenses this file + to you under the Apache License, Version 2.0 (the + "License"); you may not use this file except in compliance + with the License. You may obtain a copy of the License at + + http://www.apache.org/licenses/LICENSE-2.0 + + Unless required by applicable law or agreed to in writing, + software distributed under the License is distributed on an + "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + KIND, either express or implied. See the License for the + specific language governing permissions and limitations + under the License. +--> + +## What issue does this PR close? + +Closes #NNN. Review Comment: The template defaults to `Closes #NNN.`, which can easily be left unchanged and creates a bogus issue reference in PR descriptions. Since CONTRIBUTING.md allows minor fixes without an issue, it’s safer to default to `N/A` and keep the closing-keyword example as an HTML comment. ########## .github/pull_request_template.md: ########## @@ -0,0 +1,28 @@ +<!--- + Licensed to the Apache Software Foundation (ASF) under one + or more contributor license agreements. See the NOTICE file + distributed with this work for additional information + regarding copyright ownership. The ASF licenses this file + to you under the Apache License, Version 2.0 (the + "License"); you may not use this file except in compliance + with the License. You may obtain a copy of the License at + + http://www.apache.org/licenses/LICENSE-2.0 + + Unless required by applicable law or agreed to in writing, + software distributed under the License is distributed on an + "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + KIND, either express or implied. See the License for the + specific language governing permissions and limitations + under the License. +--> + +## What issue does this PR close? + +Closes #NNN. + +## What's Changed + +Please fill in a description of the changes here. + +**This contains breaking changes.** <- Remove this line if there are no breaking changes. Review Comment: The "breaking changes" instruction is currently visible text (including the `<-` note) that will end up in PR bodies if authors don’t edit it. Using a dedicated section with a checkbox avoids noisy placeholder text while still prompting authors. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
