alamb commented on code in PR #784:
URL:
https://github.com/apache/arrow-rs-object-store/pull/784#discussion_r3546340619
##########
src/registry.rs:
##########
@@ -215,6 +261,19 @@ impl ObjectStoreRegistry for DefaultObjectStoreRegistry {
Err(Error::NotFound.into())
}
+
+ fn deregister(&self, url: &Url) -> Option<Arc<dyn ObjectStore>> {
+ let mut map = self.map.write();
Review Comment:
minor: you could move the lock acquisition after computing the key (so right
before `map.get_mut()`) to minimize the time the lock is held
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
